Fix top-level reconciliation in portals #3020
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Visit the preview URL for this PR (updated for commit 88386fb): https://yew-rs-api--pr3020-fix-portal-reconcili-gp292iyx.web.app (expires Tue, 13 Dec 2022 07:49:12 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
Benchmark - SSRYew MasterDetails
Pull RequestDetails
|
Size ComparisonDetails
✅ None of the examples has changed their size significantly. |
ranile
approved these changes
Dec 10, 2022
Member
ranile
left a comment
ranile
left a comment
There was a problem hiding this comment.
👍
Seems like we should cut a new patch release soon
WorldSEnder
added a commit
to WorldSEnder/yew
that referenced
this pull request
Jan 10, 2023
WorldSEnder
added a commit
that referenced
this pull request
Jan 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Portals would incorrectly use their own
parentandnext_siblingto reconcile their contents since #2330. Oops. This did not affect the reconciliation of nested elements, which could be a reason this was undetected for this long.Fixes #3017
A workaround for anyone impacted by this (until the next patch release) would be to nest elements in a tag that does not change, which is not applicable in all situations.
Checklist